Review interface GUI crash when 'accept' value is not in 'options'

1

Just putting it out there, it might save people some time debugging...

I had a 2-step classification annotation (choice interface), and tasks annotated in the 1st round were just copied to the 2nd round. accept key was not cleaned up and contained the 1st round result.
In the second round (different choice options), if an annotator ignored or didn't select any option, the old value remained.

So I had tasks with task['options']:

[
   {'id': 'option_1', 'text': 'Option 1'},
   {'id': 'option_2', 'text': 'Option 2'},
]

And task['accept'] had:

['option_3']

It caused the following crash when I loaded those in review mode :

TypeError: can't access property Symbol.iterator, byId[id2] is undefined
_Review@http://localhost:8075/bundle.js:308:93199
bundle.js/createWithStyles2/</WithStyles<@http://localhost:8075/bundle.js:74:39370
_Blocks@http://localhost:8075/bundle.js:282:80025
bundle.js/createWithStyles2/</WithStyles<@http://localhost:8075/bundle.js:74:39370
div
_CardWithoutTheme@http://localhost:8075/bundle.js:308:98982
bundle.js/createWithStyles2/</WithStyles<@http://localhost:8075/bundle.js:74:39370
Card@http://localhost:8075/bundle.js:308:101216
ErrorBoundary@http://localhost:8075/bundle.js:308:141679
div
div
_Annotator@http://localhost:8075/bundle.js:308:146396
bundle.js/createWithStyles2/</WithStyles<@http://localhost:8075/bundle.js:74:39370
ConnectFunction@http://localhost:8075/bundle.js:64:13204
main
div
_class2@http://localhost:8075/bundle.js:79:44138
_Main@http://localhost:8075/bundle.js:308:163510
bundle.js/createWithStyles2/</WithStyles<@http://localhost:8075/bundle.js:74:39370
ConnectFunction@http://localhost:8075/bundle.js:64:13204
ThemeProvider3@http://localhost:8075/bundle.js:68:121977
App@http://localhost:8075/bundle.js:310:8284
Provider@http://localhost:8075/bundle.js:68:1335

Took a while to figure it out :slightly_smiling_face:

2

Thanks for sharing @nrodnova!
A good edge case to improve the validation checks on our end :+1: