Prodigy recipe on your github page appears to not work. Out of date?

matthew · February 17, 2020, 8:19am

Hi!

When trying to use your recipe found at:

explosion/prodigy-recipes/blob/master/terms/terms_teach.py

import prodigy
from prodigy.components.db import connect
from prodigy.components.sorters import Probability
from prodigy.util import split_string, set_hashes
import spacy
from spacy.tokens import Doc
from typing import List


# Recipe decorator with argument annotations: (description, argument type,
# shortcut, type / converter function called on value before it's passed to
# the function). Descriptions are also shown when typing --help.
@prodigy.recipe(
    "terms.teach",
    dataset=("The dataset to use", "positional", None, str),
    vectors=("Loadable spaCy model with word vectors", "positional", None, str),
    seeds=("One or more comma-separated seed terms", "option", "o", split_string),
)
def terms_teach(dataset: str, vectors: str, seeds: List[str]):
    """

This file has been truncated. show original

the following error repeatedly appears in the console, and words never load in the interface:

"Evaluating lexeme.similarity based on empty vectors"

I am running the recipe via:

prodigy terms.teach test1 en_vectors_web_lg --seeds "knitting, yarn, wool, jumper" -F matt-teach.py

I am hoping to use this file as a base to begin my own custom recipe changes from.

ines · February 17, 2020, 2:56pm

Hi! The terms.teach recipe works by iterating over the model's vocab, and the warning is shown by spaCy if one or more tokens of a similarity query do not have a vector. So basically, the en_vectors_web_lg vocab includes words without vectors, and those trigger the warnings. This also makes the similarity queries slower, so the stream takes longer to load.

The easiest solution is to just skip words with no vectors, e.g. by changing line 71 to this:

lexemes = [w for w in lexemes if w.orth not in seen and w.vector_norm]

This is probably a useful general-purpose fix we should also add to the recipe in the recipes repo.

matthew · February 17, 2020, 3:27pm

Thanks for the reply.

The same command works absolutely perfectly via terms.teach (e.g. not pointing to a local file), using the exact same seed words and exact same Spacy model.

e.g.
prodigy terms.teach test1 en_vectors_web_lg --seeds "knitting, yarn, wool, jumper"

works quickly and without issue.

Whereas running your recipe from theGithub page causes the error. Hence I think there must have been a change that has not been applied to the Github version of terms.teach that you have listed in your Github recipes catalogue. If those recipes are there for us to use, then I think it is worth editing them accordingly.

ines · February 17, 2020, 3:44pm

Yes, that's the change I mentioned above It's related to a change in spaCy v2.1 and we should definitely port this over to the recipes repo. Edit: Update here!

(In general, the scripts in prodigy-recipes aren't always 100% identical to the recipes shipped with the library – they're often simplified to focus on the core functionality and to make it easy to adapt them for custom recipes.)

Topic		Replies	Views
terms.teach not showing contextual words done , spacy , terms , solved	3	722	July 2, 2020
Error when seeds in terms.teach include empty string done , spacy , terms	4	760	October 4, 2017
Error when adding seed terms to terms.teach done , terms , solved	8	1985	September 5, 2021
Bad results with terms.teach terms , solved	12	2225	August 26, 2020
Problem with creating terminology list after upgrade to 2.1 done , spacy , terms , solved	10	1375	May 28, 2019

Prodigy recipe on your github page appears to not work. Out of date?

Related Topics